Always set log level on telemetry logs #8916
Draft
+56
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027676
Total [baseline] (8.632 s) : 0, 8631545
Agent [candidate] (1.033 s) : 0, 1032722
Total [candidate] (8.548 s) : 0, 8548234
section iast
Agent [baseline] (1.167 s) : 0, 1167077
Total [baseline] (9.29 s) : 0, 9290121
Agent [candidate] (1.152 s) : 0, 1152033
Total [candidate] (9.204 s) : 0, 9204252
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.876 ms) : 0, 686876
BytebuddyAgent [candidate] (690.543 ms) : 0, 690543
GlobalTracer [baseline] (242.93 ms) : 0, 242930
GlobalTracer [candidate] (243.425 ms) : 0, 243425
AppSec [baseline] (59.618 ms) : 0, 59618
AppSec [candidate] (58.033 ms) : 0, 58033
Debugger [baseline] (6.258 ms) : 0, 6258
Debugger [candidate] (6.264 ms) : 0, 6264
Remote Config [baseline] (674.7 µs) : 0, 675
Remote Config [candidate] (672.947 µs) : 0, 673
Telemetry [baseline] (10.487 ms) : 0, 10487
Telemetry [candidate] (12.763 ms) : 0, 12763
section iast
BytebuddyAgent [baseline] (816.501 ms) : 0, 816501
BytebuddyAgent [candidate] (805.444 ms) : 0, 805444
GlobalTracer [baseline] (234.68 ms) : 0, 234680
GlobalTracer [candidate] (232.172 ms) : 0, 232172
IAST [baseline] (26.389 ms) : 0, 26389
IAST [candidate] (26.847 ms) : 0, 26847
AppSec [baseline] (53.841 ms) : 0, 53841
AppSec [candidate] (52.273 ms) : 0, 52273
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (611.599 µs) : 0, 612
Remote Config [candidate] (600.399 µs) : 0, 600
Telemetry [baseline] (8.096 ms) : 0, 8096
Telemetry [candidate] (8.017 ms) : 0, 8017
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046723
Total [baseline] (10.743 s) : 0, 10743118
Agent [candidate] (1.033 s) : 0, 1032936
Total [candidate] (10.66 s) : 0, 10660421
section appsec
Agent [baseline] (1.188 s) : 0, 1188072
Total [baseline] (10.897 s) : 0, 10896867
Agent [candidate] (1.179 s) : 0, 1178705
Total [candidate] (10.768 s) : 0, 10768176
section iast
Agent [baseline] (1.156 s) : 0, 1155920
Total [baseline] (10.99 s) : 0, 10989623
Agent [candidate] (1.159 s) : 0, 1158915
Total [candidate] (10.953 s) : 0, 10953457
section profiling
Agent [baseline] (1.278 s) : 0, 1277648
Total [baseline] (10.979 s) : 0, 10979465
Agent [candidate] (1.271 s) : 0, 1270581
Total [candidate] (10.979 s) : 0, 10978654
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.13 ms) : 0, 701130
BytebuddyAgent [candidate] (691.375 ms) : 0, 691375
GlobalTracer [baseline] (247.151 ms) : 0, 247151
GlobalTracer [candidate] (243.711 ms) : 0, 243711
AppSec [baseline] (59.164 ms) : 0, 59164
AppSec [candidate] (58.548 ms) : 0, 58548
Debugger [baseline] (7.219 ms) : 0, 7219
Debugger [candidate] (7.054 ms) : 0, 7054
Remote Config [baseline] (698.17 µs) : 0, 698
Remote Config [candidate] (684.299 µs) : 0, 684
Telemetry [baseline] (10.073 ms) : 0, 10073
Telemetry [candidate] (10.454 ms) : 0, 10454
section appsec
BytebuddyAgent [baseline] (713.634 ms) : 0, 713634
BytebuddyAgent [candidate] (708.079 ms) : 0, 708079
GlobalTracer [baseline] (236.793 ms) : 0, 236793
GlobalTracer [candidate] (235.048 ms) : 0, 235048
IAST [baseline] (22.062 ms) : 0, 22062
IAST [candidate] (21.806 ms) : 0, 21806
AppSec [baseline] (180.73 ms) : 0, 180730
AppSec [candidate] (179.247 ms) : 0, 179247
Debugger [baseline] (5.894 ms) : 0, 5894
Debugger [candidate] (5.794 ms) : 0, 5794
Remote Config [baseline] (621.432 µs) : 0, 621
Remote Config [candidate] (626.937 µs) : 0, 627
Telemetry [baseline] (7.347 ms) : 0, 7347
Telemetry [candidate] (7.358 ms) : 0, 7358
section iast
BytebuddyAgent [baseline] (806.961 ms) : 0, 806961
BytebuddyAgent [candidate] (810.784 ms) : 0, 810784
GlobalTracer [baseline] (233.372 ms) : 0, 233372
GlobalTracer [candidate] (233.009 ms) : 0, 233009
IAST [baseline] (26.878 ms) : 0, 26878
IAST [candidate] (27.821 ms) : 0, 27821
AppSec [baseline] (53.068 ms) : 0, 53068
AppSec [candidate] (51.667 ms) : 0, 51667
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (615.868 µs) : 0, 616
Remote Config [candidate] (603.431 µs) : 0, 603
Telemetry [baseline] (8.068 ms) : 0, 8068
Telemetry [candidate] (8.102 ms) : 0, 8102
section profiling
BytebuddyAgent [baseline] (681.937 ms) : 0, 681937
BytebuddyAgent [candidate] (676.335 ms) : 0, 676335
GlobalTracer [baseline] (363.419 ms) : 0, 363419
GlobalTracer [candidate] (361.448 ms) : 0, 361448
AppSec [baseline] (62.312 ms) : 0, 62312
AppSec [candidate] (62.252 ms) : 0, 62252
Debugger [baseline] (6.227 ms) : 0, 6227
Debugger [candidate] (6.209 ms) : 0, 6209
Remote Config [baseline] (707.996 µs) : 0, 708
Remote Config [candidate] (719.57 µs) : 0, 720
Telemetry [baseline] (8.211 ms) : 0, 8211
Telemetry [candidate] (8.173 ms) : 0, 8173
ProfilingAgent [baseline] (105.925 ms) : 0, 105925
ProfilingAgent [candidate] (106.8 ms) : 0, 106800
Profiling [baseline] (105.949 ms) : 0, 105949
Profiling [candidate] (106.825 ms) : 0, 106825
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (4.354 ms) : 4303, 4406
. : milestone, 4354,
iast (9.246 ms) : 9089, 9402
. : milestone, 9246,
iast_FULL (13.744 ms) : 13474, 14013
. : milestone, 13744,
iast_GLOBAL (10.051 ms) : 9875, 10227
. : milestone, 10051,
profiling (8.919 ms) : 8781, 9056
. : milestone, 8919,
tracing (7.774 ms) : 7663, 7884
. : milestone, 7774,
section candidate
no_agent (4.291 ms) : 4243, 4339
. : milestone, 4291,
iast (9.153 ms) : 8997, 9309
. : milestone, 9153,
iast_FULL (14.095 ms) : 13811, 14379
. : milestone, 14095,
iast_GLOBAL (10.176 ms) : 9982, 10371
. : milestone, 10176,
profiling (8.951 ms) : 8796, 9106
. : milestone, 8951,
tracing (7.587 ms) : 7481, 7693
. : milestone, 7587,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (38.172 ms) : 37863, 38481
. : milestone, 38172,
appsec (46.787 ms) : 46375, 47199
. : milestone, 46787,
code_origins (44.165 ms) : 43806, 44523
. : milestone, 44165,
iast (44.04 ms) : 43661, 44419
. : milestone, 44040,
profiling (48.042 ms) : 47636, 48449
. : milestone, 48042,
tracing (42.998 ms) : 42658, 43339
. : milestone, 42998,
section candidate
no_agent (38.789 ms) : 38464, 39114
. : milestone, 38789,
appsec (46.823 ms) : 46422, 47225
. : milestone, 46823,
code_origins (43.929 ms) : 43573, 44286
. : milestone, 43929,
iast (45.396 ms) : 45000, 45793
. : milestone, 45396,
profiling (49.394 ms) : 48932, 49855
. : milestone, 49394,
tracing (43.797 ms) : 43444, 44151
. : milestone, 43797,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.395 ms) : 2346, 2444
. : milestone, 2395,
iast (2.183 ms) : 2122, 2244
. : milestone, 2183,
iast_GLOBAL (2.229 ms) : 2167, 2291
. : milestone, 2229,
profiling (2.031 ms) : 1982, 2080
. : milestone, 2031,
tracing (1.995 ms) : 1947, 2042
. : milestone, 1995,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.386 ms) : 2338, 2435
. : milestone, 2386,
iast (2.191 ms) : 2130, 2252
. : milestone, 2191,
iast_GLOBAL (2.224 ms) : 2163, 2286
. : milestone, 2224,
profiling (2.027 ms) : 1978, 2076
. : milestone, 2027,
tracing (2.0 ms) : 1952, 2047
. : milestone, 2000,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1b2fb11f39, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
appsec (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (18.076 s) : 18076000, 18076000
. : milestone, 18076000,
profiling (15.321 s) : 15321000, 15321000
. : milestone, 15321000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
section candidate
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
iast (18.557 s) : 18557000, 18557000
. : milestone, 18557000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
. : milestone, 18013000,
profiling (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
tracing (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
|
AlexeyKuznetsov-DD
requested changes
Jun 3, 2025
Comment on lines
+24
to
+51
| void 'log with unknown log level is normalized to DEBUG'() { | ||
| LogMessage logMessage | ||
|
|
||
| when: | ||
| LogCollector.get().addLogMessage("INFO", "test", null) | ||
| periodicAction.doIteration(telemetryService) | ||
|
|
||
| then: | ||
| 1 * telemetryService.addLogMessage(_) >> { args -> logMessage = args[0] } | ||
| 0 * _ | ||
| logMessage.getLevel() == LogMessageLevel.DEBUG | ||
| logMessage.getMessage() == 'test' | ||
| } | ||
|
|
||
| void 'log with null log level is normalized to DEBUG'() { | ||
| LogMessage logMessage | ||
|
|
||
| when: | ||
| LogCollector.get().addLogMessage(null, "test", null) | ||
| periodicAction.doIteration(telemetryService) | ||
|
|
||
| then: | ||
| 1 * telemetryService.addLogMessage(_) >> { args -> logMessage = args[0] } | ||
| 0 * _ | ||
| logMessage.getLevel() == LogMessageLevel.DEBUG | ||
| logMessage.getMessage() == 'test' | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggestion: how about to combine into one test using where: part?
There was a problem hiding this comment.
Makes sense.
Anyway, I'm holding off, as an alternative might be accepting INFO in the backend. The log level exists there, but it's currently rejected at intake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Default telemetry log level to
DEBUG.Motivation
Our telemetry system has only 3 log levels:
ERROR,WARN, andDEBUG, and setting a level is mandatory. That means we're currently skipping the field forINFOlevel.Additional Notes
Thanks to @sezen-datadog for the heads up.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]